-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
June 2019 Training reaction fixing hackathon #340
Open
mjohnson541
wants to merge
36
commits into
main
Choose a base branch
from
hackathon_June2019
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed database label issue for: Family = H_Abstraction, Species = NH3, NH2
Fixed database label issue for: Family = H_Abstraction, Species = CH4, CH3
Fixed database label issue for: Family = H_Abstraction, Species = H2O, OH
Fixed database label issue for: Family = Disproportionation, Species = CH3
… the highest rates per reaction family for unimolecular and bimolecular reactions at a discrete temperature.
…produce the highest rates per reaction family for unimolecular and bimolecular reactions at a discrete temperature.
Missing thermochemistry for species COOOC seems to be the problem
I deleted training reaction 824 because its reverse rate was above the upper limit of the unimolecular reaction
Including all guesses and Aaron Vandeputte small GA method estimates Especially because they were converted from rate rules and may not match the original species they were estimated for
Reaction comment included actual species used in calculation Conversion assumed incorrect species
Rank 10 entries removed in favor of Rank 5 and 4
…hat need to be checked for Intra_R_Add_Endocyclic.
…hat need to be checked and removed Collision Limit Violators in R_Addition_MultipleBond.
…hat need to be checked and removed Collision Limit Violators in R_Recombination.
…ank 10 in favor to rank 5.
… in favor to rank 5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hackathon had two objectives:
Emergent considerations:
Removing GAV estimate training reactions
Removing training reactions with small temperature ranges
Once this PR is ready to be merged remember to remove the filter threshold caps in RMG-Py. The cap values are the old filter threshold values and introduced to avoid slowdown of RMG if the "high-pressure" Arrhenius fits are unreasonably high based on the current RMG-database master.